Week6mastermind #10
Open
Week6mastermind #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2017 17:47
reneemeyer
suggested changes
Aug 31, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Renata, over all nice job. I really like your white boarding. However, upon testing, I was unable to check the guess or display a hint. You're almost there, you just need to fix a few es6 things and possibly some functionality bugs.
| boardColorsCanvas.setAttribute('class', 'palette'); | ||
| // boardColorsCanvas.setAttribute('class', 'boardColors') | ||
| // const boardColorsCanvas = document.getElementById('boardColors') | ||
| for(let i = 0; i < boardColors.length; i++){ |
There was a problem hiding this comment.
You should use a map or for each here.
| document.addEventListener('DOMContentLoaded', () => { | ||
|
|
||
| let boardColors = ['red', 'blue', 'green', 'white', 'yellow', 'purple', 'orange', 'black']; | ||
| let generatedAnswer = []; |
| populateChoice(color); | ||
| }); | ||
| boardColorsCanvas.appendChild(chooseSection); | ||
| let theBody = document.getElementsByTagName('body')[0]; |
| // boardColorsCanvas.setAttribute('class', 'boardColors') | ||
| // const boardColorsCanvas = document.getElementById('boardColors') | ||
| for(let i = 0; i < boardColors.length; i++){ | ||
| let chooseSection = document.createElement('div'); |
| <body> | ||
| <script type="text/javascript" src="./script.js"></script> | ||
|
|
||
| <div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3