Checkpoint1 #7
Open
Checkpoint1 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieroapretto
reviewed
Aug 5, 2017
| function mastermind(guess) { | ||
| if (guess === generatedCode) { | ||
| console.log('You win!'); | ||
| return; |
There was a problem hiding this comment.
You need to return your "win" statement here, instead of just console logging here.
See line 161 to test instructions.
| if (gueArray[3] === genArray[3]) { | ||
| positionCounter+=1; | ||
| } | ||
| console.log('you have '+positionCounter+' letters in the correct position'); |
There was a problem hiding this comment.
Return statement here showing correct letters and correct letter locations.
| console.log('you have '+counter+' correct letters'); | ||
|
|
||
| let positionCounter=0; | ||
| if (gueArray[0] === genArray[0]) { |
There was a problem hiding this comment.
Consolidate lines 121-132 using a for loop and indexof() to check your guess against solution.
|
|
||
| for(let i = 0; i < gueArray.length;i++) | ||
| { | ||
| for(let j=0; j < genArray.length;j++) |
| for(let j=0; j < genArray.length;j++) | ||
| { | ||
| if (gueArray[i]===genArray[j]) | ||
| counter+=1; |
There was a problem hiding this comment.
Could also use ++ here to increment by one.
| gameCounter+=1; | ||
| if (gameCounter > 10) { | ||
| console.log("GAME OVER!!") | ||
| return; |
There was a problem hiding this comment.
Remove empty return statements from your code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3