feat(api): audio-source metadata enriched with file byteSize#723
Open
feat(api): audio-source metadata enriched with file byteSize#723
Conversation
… to the duration in ms
Contributor
Author
|
Mit diesem Artikel getestet: https://publikator.republik.love/repo/republik/love-article-adf/tree |
hdahlheim
approved these changes
Feb 23, 2024
lucianak
reviewed
Feb 23, 2024
| @@ -102,7 +104,7 @@ const handleBatch = async (rows: any[], count: number, pgdb: any) => { | |||
| return | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This script probably woudln't work correctly like this, you would also need to check for audioSourceByteSize in the checks above. But afaik this script was used to add a synthetic voice to all past articles, so probably it isn't that relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the durationMS being fetched for an attached audioSource, the byteSize is now also attached to the commit meta-data.