Support for bundling locales#2
Support for bundling locales#2klocatelli wants to merge 1 commit intorequirejs:masterfrom klocatelli:localeBundling
Conversation
|
I created a fork precissely to do that. With this change, the "locale" parameter in the config file accepts an array of locales. If that is the case, all the locales in the array are included in the bundle. |
|
I've defined and my In defines and requires I only use Is this normal behaviour ? I was expecting that defining I will try your fork to see if it works then, thank you! |
|
I encountered, is there any solution? |
|
👍 i would be for this. i defined a custom module in my r.js config and the plugin still loads it from the unbundled location. |
|
Any updates on that? Does someone found a solution? @daniel-white can you share your custom module, your work around please? :) |
|
@henriquea i don't have a workaround at this time. my custom module is just a load layer that my build scripts used. |
|
@daniel-white thanks mate. In the end I had to remove this from my project and I'm using one single module with all the locales. It's a shame, I'll follow this thread to see what happens. |
Optimizing with r.js doesn't inline locales unless they're specifically required. This is an inconvenience when using almond.js and/or a small set of translations.
Attached commit should fix that. Requires a new inlining flag to be set and true in order to run the "inline everything" process, otherwise does the same thing as before.