-
Notifications
You must be signed in to change notification settings - Fork 0
Update package manager version, remove ignored dependency, and enhanc… #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e search index content - Updated package manager version in package.json from pnpm@10.20.0 to pnpm@10.27.0. - Removed 'inotify' from the list of ignored built dependencies in pnpm-workspace.yaml. - Revised content in public/search-index.json for clarity and accuracy regarding lexical and dynamic scoping in JavaScript.
PR Summary
Written by Cursor Bugbot for commit b61d231. This will update automatically on new commits. Configure here. |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR updates the pnpm package manager version from 10.20.0 to 10.27.0, removes inotify from workspace build dependencies, and fixes typos in blog article content about lexical and dynamic scope. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| onlyBuiltDependencies: | ||
| - '@tailwindcss/oxide' | ||
| - inotify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong pnpm config list: allowlist vs ignore list
The PR description says inotify was removed from "ignored built dependencies" but it was actually removed from onlyBuiltDependencies (an allowlist). These have opposite effects: ignoredBuiltDependencies skips build scripts, while onlyBuiltDependencies is an allowlist of packages permitted to run build scripts. Since inotify is a native C++ addon (dependency of dev package) that requires compilation, removing it from the allowlist prevents its build scripts from running, which may break the package functionality. The change does the opposite of what the PR description implies was intended.
…e search index content
Summary by CodeRabbit
Release Notes
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.