Skip to content

Conversation

@area73
Copy link
Collaborator

@area73 area73 commented Jan 6, 2026

…e search index content

  • Updated package manager version in package.json from pnpm@10.20.0 to pnpm@10.27.0.
  • Removed 'inotify' from the list of ignored built dependencies in pnpm-workspace.yaml.
  • Revised content in public/search-index.json for clarity and accuracy regarding lexical and dynamic scoping in JavaScript.

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated package manager to a newer version
    • Adjusted workspace build dependencies configuration
  • Documentation

    • Fixed typos and improved wording in blog article on lexical and dynamic scope

✏️ Tip: You can customize this high-level summary in your review settings.

…e search index content

- Updated package manager version in package.json from pnpm@10.20.0 to pnpm@10.27.0.
- Removed 'inotify' from the list of ignored built dependencies in pnpm-workspace.yaml.
- Revised content in public/search-index.json for clarity and accuracy regarding lexical and dynamic scoping in JavaScript.
@cursor
Copy link

cursor bot commented Jan 6, 2026

PR Summary

  • Build tooling: Update package.json packageManager to pnpm@10.27.0.
  • Workspace config: Remove inotify from pnpm-workspace.yaml onlyBuiltDependencies.
  • Search index: Refresh public/search-index.json with corrected content for lexical-and-dynamic-scope entry.

Written by Cursor Bugbot for commit b61d231. This will update automatically on new commits. Configure here.

@area73 area73 merged commit 6c99a79 into master Jan 6, 2026
2 of 9 checks passed
@area73 area73 deleted the gtm-to-analytics2 branch January 6, 2026 12:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR updates the pnpm package manager version from 10.20.0 to 10.27.0, removes inotify from workspace build dependencies, and fixes typos in blog article content about lexical and dynamic scope.

Changes

Cohort / File(s) Summary
Package Manager Configuration
package.json
Updated pnpm version from 10.20.0 to 10.27.0
Workspace Configuration
pnpm-workspace.yaml
Removed inotify from onlyBuiltDependencies list
Documentation Content
public/search-index.json
Fixed typos and wording issues in English blog article (e.g., "eval keywod" → "eval keyword", "afected" → "affected", "witch" → "which")

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a skip, a version bump so keen,
Dependencies pruned from the build machine,
Typos corrected with a careful touch,
Small fixes that matter—not much, yet so much!


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07e5446 and b61d231.

📒 Files selected for processing (3)
  • package.json
  • pnpm-workspace.yaml
  • public/search-index.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.


onlyBuiltDependencies:
- '@tailwindcss/oxide'
- inotify
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pnpm config list: allowlist vs ignore list

The PR description says inotify was removed from "ignored built dependencies" but it was actually removed from onlyBuiltDependencies (an allowlist). These have opposite effects: ignoredBuiltDependencies skips build scripts, while onlyBuiltDependencies is an allowlist of packages permitted to run build scripts. Since inotify is a native C++ addon (dependency of dev package) that requires compilation, removing it from the allowlist prevents its build scripts from running, which may break the package functionality. The change does the opposite of what the PR description implies was intended.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants