Merged
Conversation
- Add new dice.py module with Die and Coin distribution classes - Die supports exploding dice mechanics via explode_on parameter - Both Die and Coin are OperableDistribution subclasses - Deprecate roll_die() and flip_coin() utility functions - Update samplers.py with die_sample() and coin_sample() functions - Add comprehensive tests for new dice module - Update README.md with new dice/coin usage examples - Update CHANGES.md with new feature documentation
These utility functions have been replaced by the new die() and coin() distribution objects. Since the library is not yet at a stable release and these weren't popular features, removing them entirely instead of deprecating.
Closed
- Assert actual seeded values in test_die_basic and test_coin_basic - Add OperableDistribution assertions in test_die_is_operable and test_coin_is_operable to match test descriptions - Remove dead _single_roll_v2 naming, now just _single_roll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.