Skip to content

[COA-2971] Fix Union interval bounds validation to prevent panic #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjaus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[COA-2971] Fix Union interval bounds validation to prevent panic #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions interval/interval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,13 @@ func Union(a []Interval, b []Interval) []Interval {
i++
}

result = append(result, Interval{
Start: start,
End: end,
})
// Only append if the intervals actually overlap (start <= end)
if start <= end {
result = append(result, Interval{
Start: start,
End: end,
})
}
}

return joinSortedIntervals(result)
Expand Down
22 changes: 22 additions & 0 deletions interval/interval_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,28 @@ func TestUnion(t *testing.T) {
{Start: 5, End: 5},
},
},
{
name: "non-overlapping intervals should produce empty result",
a: []interval.Interval{
{Start: 90, End: 95},
},
b: []interval.Interval{
{Start: 80, End: 88},
},
e: []interval.Interval{},
},
{
name: "adjacent but non-overlapping intervals",
a: []interval.Interval{
{Start: 10, End: 20},
{Start: 50, End: 60},
},
b: []interval.Interval{
{Start: 21, End: 30},
{Start: 40, End: 49},
},
e: []interval.Interval{},
},
}

for _, tc := range testacses {
Expand Down
Loading