Open
Conversation
Zergleb
approved these changes
Nov 15, 2021
Zergleb
reviewed
Nov 20, 2021
|
|
||
| function mapMirror(key) { | ||
| var map = { | ||
| "austrailia": "http://www.csse.monash.edu.au/~jwb/cgi-bin/wwwjdic?", |
There was a problem hiding this comment.
You update the map but you don't update the row above with the correct keys. On my repo I pulled these out and made this map a const and replaced the row above with map.keys() to keep them forever in sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR updates the mirror list based on the current info at: https://www.edrdg.org/wwwjdic/wwwjdicmirrors.html
In summary:
australia_monashandaustralia_melbourne. I leftaustrailiafor backwards compatibility and updated it to point to the monash mirror (the previous address 302 redirects there).