Skip to content

Conversation

@gvollant
Copy link

some compatibility patch are from previous pull request

Pull requet #25 was accidentelly closed, so I reopen this PR

for smartversion compile (including android), some compatibility patch are from previous pull request
@gvollant
Copy link
Author

@janisozaur @richgel999 can you look at #27

@gvollant
Copy link
Author

@richgel999 I made a minor update to compile on macos 11 on arm64

I'll be happy if you take a look !

@gvollant
Copy link
Author

@janisozaur you can also look

@janisozaur
Copy link

My objection regarding improper commit message still stands

@janisozaur
Copy link

modification for compatibility for smartversion compile (including android), some compatibility patch are from previous pull request

is not something I would ever want to see as a commit. It does not explain what the "modification for compatibility" is; "modification", as in "code change" is already implied; the "previous pull request" doesn't refer to anything in particular.

The subject line should be glanceable and short, written in imperative mode and above all, should actually explain what it does.

E.g.:

Improve Android support

or

Extend Android support with better memory allocation

or something in that vein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants