Add Sendable protocol to TaskQueue#3
Draft
theisegeberg wants to merge 1 commit intorickymohk:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases it's nice to create a global public
TaskQueue, and for that it needs to be sendable.I know this is a "cold PR", but I just stumbled upon your solution to this problem after making my own semaphore based version. And I liked yours a lot better, but ran straight into needing to make it sendable to support a global variable :-) - great work BTW, thank your for taking our time to polish and finish this.
It's not complete in any way, so this is a draft :-) I didn't want to just hi-jack with a ton of code.