Update csproj to latest format and target netstandard1.0 and PCL (portable-net45+win8+wp8)#170
Update csproj to latest format and target netstandard1.0 and PCL (portable-net45+win8+wp8)#170Mark-RSK wants to merge 30 commits intorid00z:masterfrom
Conversation
|
For a working netstandard Xamarin Forms template the following link has a great explanation, and also a repo with the template included. https://oren.codes/2017/04/23/using-xamarin-forms-with-net-standard-vs-2017-edition/ |
|
I think the line count reduction of ~11,000 lines speaks to Oren's idea that .NET Standard reduces "gunk". |
Allows the use of PCL with the netstandard build
|
@Mark-RSK I came here because I need FreshMVVM to work with Rx.NET with .NET standards 1.6 support. |
|
[FreshMVVm + ReactiveUI ]+ ReactiveExtension |
|
@JimSEOW I have updated the project to use the PackageTargetFallback attribute in the csproj so the stable release of Xamarin Forms is used. I have also removed the PCL output of the library as this caused issues in Visual Studio Mac |
|
The FreshMVVM.Tests complains!
|
|
@Mark-RSK Why I have to keep the FreshMVVM to .NET standard 1.0 and not 1.4 (causing errors in TinyIoC.cs) However, now that It compiles, I can NOW start combining ReactiveUI and ReactiveExtension to target UWP .net standard 1.4 (so that when UWP is .NET standard 2.0 compliance, we would have learn many issues before then). |
|
@JimSEOW It seems TinyIoC hasn't been updated in a while and the ifdefs were incorrect for net standard 1.4. I have updated the ifdef's to include 1.3 & 1.4 and it now all compiles. I apologise for the earlier checkin that failed to build. I had changed the csproj type of the test project from netstandard to net461 on my master branch but hadn't made the change in this branch. |
|
I am waiting for this! Nice work :) |
|
@Mark-RSK thanks. |
|
@Mark-RSK These are the failed tests |
|
@JimSEOW I've fixed the failing tests. Not sure the tests would have passed on the original master branch. I am unable to build the original master to check |
|
Building the original branch in VS2015 and running the tests, the same tests fail |
|
I'll take a look at integrating this asap. I'm away from computer for the
next week but I can take a look at this on return.
Thanks
On Sat, 12 Aug 2017 at 4:59 pm, Mark Pitt ***@***.***> wrote:
Building the original branch in VS2015 and running the tests, the same
tests fail
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#170 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABeXvQwcz8zjWlpud14X70s_7Od9qiSjks5sXWmMgaJpZM4OTQJ4>
.
--
[image: XAM-Consulting Pty Ltd] <http://www.xam-consulting.com/>
[image: Twitter] <https://twitter.com/XAMConsulting> [image: LinkedIn]
<https://www.linkedin.com/company-beta/5791295/>
Michael Ridland / Director / Xamarin & Microsoft MVP
michael@xam-consulting.com / 0404 865 350
XAM Consulting Pty. Limited.
Web | Cloud | Apps | Xamarin
210/29 Kiora Rd, Miranda NSW 2228
xam-consulting.com <http://www.xam-consulting.com/>
|
|
Without wishing to be rude/pushy, is there any progress on merging this PR? Thanks :-) |
|
@daveclarke @Mark-RSK @jfversluis Apologies for the slow reply, we've upgrade to .NET Standard already but there's a few nice commits/ideas in here that I will take a look at. |

I have updated all nuget references and included the latest Xamarin.Forms that has a netstandard target. To allow the project to build correctly for netstandard and use the inbuilt nuget packing in VS2017 I have moved the IOC files into the main project.
I have tested bringing in the compiled nuget into both a netstandard and PCL XF core project and both function correctly.
Your thoughts on the implementation would be much appreciated as I have attempted this as a way of learning the new csproj structure