Refactored markup file loader to be extensible by third-party libraries#1312
Refactored markup file loader to be extensible by third-party libraries#1312tomasherceg wants to merge 3 commits intomainfrom
Conversation
exyi
left a comment
There was a problem hiding this comment.
Instead of this, I think we can just import IEnumerable<IMarkupFileLoader> from DI. It's harder to control the order of registration that way, but it shouldn't matter in most cases (the loader prefixes should be distinct)
|
It's not that easy - the Hot Reload is done also by a special loader which basically decorates the default file-system loader. |
|
I've been looking at this again, and the problem is that the order of services returned by
I see two ways how to solve the issue:
|
|
You can keep the |
Currently, it was not possible to extend the
AggregateMarkupFileLoaderto support special pages (similar toembedded://...format and so on).I've created
AggregateMarkupFileOptionswhich specifies the types and the order of concrete markup file loaders.These loaders must be registered in DI, but anyone can add custom loaders like this: