Added repro for a bug with passing commands in markup controls#1742
Open
tomasherceg wants to merge 4 commits intomainfrom
Open
Added repro for a bug with passing commands in markup controls#1742tomasherceg wants to merge 4 commits intomainfrom
tomasherceg wants to merge 4 commits intomainfrom
Conversation
Member
|
I fixed the error message, otherwise the behavior looks "fine" to me.
Using the value binding to call commands is definitely not recommended, commands should only be invoked from command or staticCommand bindings. |
Member
Author
|
The |
exyi
added a commit
that referenced
this pull request
Jan 27, 2024
The interpreter is broken, it causes problems in #1742. The bug is reported in dotnet, without any response yet: dotnet/runtime#96385
exyi
added a commit
that referenced
this pull request
Jan 27, 2024
The interpreter is broken, it causes problems in #1742. The bug is reported in dotnet, without any response yet: dotnet/runtime#96385
exyi
added a commit
that referenced
this pull request
Jan 31, 2024
The interpreter is broken, it causes problems in #1742. The bug is reported in dotnet, without any response yet: dotnet/runtime#96385
Member
Author
|
I have to add tests here. |
exyi
approved these changes
Feb 8, 2024
tomasherceg
force-pushed
the
fix/command-properties
branch
from
b974849 to
6d676be
Compare
Member
Author
|
We need to add additional checks:
|
exyi
added a commit
that referenced
this pull request
Apr 26, 2025
In command bindings, expressions get automatically wrapped in a lambda function. Surprisingly, the behavior was also present in value/resource, which lead to some surprising effects when value/resource was accidentally assigned to a command property (#1742). We also unify that untyped ICommandBinding and IStaticCommandBinding produce delegate of type Command (i.e. async function with no argument and no return value). Previously Delegate was used for commands, which had the effect of sending the return value to the client
exyi
added a commit
that referenced
this pull request
Jun 1, 2025
In command bindings, expressions get automatically wrapped in a lambda function. Surprisingly, the behavior was also present in value/resource, which lead to some surprising effects when value/resource was accidentally assigned to a command property (#1742). We also unify that untyped ICommandBinding and IStaticCommandBinding produce delegate of type Command (i.e. async function with no argument and no return value). Previously Delegate was used for commands, which had the effect of sending the return value to the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a strange bug - probably caused by missing validation of delegates passed to DotVVM properties.
I've added a repro
/FeatureSamples/MarkupControl/CommandAsPropertyPagebut I cannot find the place where to fix it.