Draft
Conversation
- Create ValidationErrorsCount.cs control that displays validation error count - Support for IncludeErrorsFromChildren and IncludeErrorsFromTarget properties - Support for InvalidCssClass property to apply CSS class when errors exist - Support for WrapperTagName property (default: span) - Add JavaScript binding handler in validation.ts - Add unit tests for the new control Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
- Add initial execution of updateErrorCount in JS to show count immediately - Add documentation clarifying IncludeErrorsFromChildren default differs from ValidationSummary Co-authored-by: tomasherceg <5599524+tomasherceg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add validation errors count control
Add ValidationErrorsCount control
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New control similar to
ValidationSummarythat displays only the count of validation errors in the currentValidation.Target.Changes
ValidationErrorsCount.cs- New control with:IncludeErrorsFromChildren(default:true) - count errors from nested objectsIncludeErrorsFromTarget(default:true) - count errors from target itselfInvalidCssClass- CSS class applied when errors existWrapperTagName(default:span) - customizable wrapper tagvalidation.ts- Addeddotvvm-validationErrorsCountKnockout binding handlerUsage
Note:
IncludeErrorsFromChildrendefaults totrue(unlikeValidationSummarywhich defaults tofalse) per the issue requirements.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)1p7vsblobprodcus324.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)1s1vsblobprodcus386.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/Tests/DotVVM.Samples.Tests.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep orking/emptyFakeDotnetRoot working/emptyFakeDotnetRoot gCompilationTests.cs rgo/bin/grep(dns block)4m6vsblobprodcus384.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)7devsblobprodcus323.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/00DA3BA51762B14D47D4C9F6E8A232CB/missingpackages_workingdir --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force -l testoutputs/ValidationErrorsCountTests.ValidationErrorsCount_WithValidationDisabled.html sts.cs rep(dns block)cflvsblobprodcus383.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/Samples/Tests/CompletenessChecker/DotVVM.Samples.Tests.CompletenessChecker.csproj --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l /Resources/Scrip-exec sts.cs cal/bin/grep(dns block)jd4vsblobprodcus366.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)k4kvsblobprodcus344.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)m6xvsblobprodcus342.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)pdfvsblobprodcus380.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)pe3vsblobprodcus354.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)yttvsblobprodcus357.vsblob.vsassets.io/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/dotvvm/dotvvm/src/DotVVM.sln --packages /home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/dotvvm/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot grep -l y rHtmlSpecialElem--delta-base-offset rgo/bin/grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.