Fix of checkedValue behavior in Knockout#1982
Merged
tomasherceg merged 1 commit intomainfrom Jan 9, 2026
Merged
Conversation
exyi
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found an issue in the Business Pack GridView row selection mechanism, implemented using the CheckBox control. When the user switched to another page, the checkbox states were behaving weirdly.
I found out that it is actually a "feature" of Knockout - when a checkbox is checked and its
checkedValuechanges, it also updates thecheckedItemscollection to keep the checkbox checked.I think this should not be done implicitly - if someone wants this behavior, they can update both
checkedValueandcheckedItems. This is consistent with other places in DotVVM where we typically keep "invalid" items in selected-item collections, since they may appear in the data source later.I changed the behavior in our fork of Knockout (riganti/knockout#3) to apply only to DotVVM checkboxes.