Experiment: Collections with property keys#1985
Draft
tomasherceg wants to merge 3 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when we receive a modified collection from the server, DotVVM updates the client viewmodel by either expanding or shrinking the collection and potentially reusing the first N observables.
For example, when we remove a record from the middle of the collection, it removes the last element and updates the data in the elements that were shifted. This generates many client-side events that degrade performance, and it also prevents us from introducing new features, such as the animated
foreachbinding where the items could appear or disappear using transitions.This is just an experiment that needs to be further expanded:
[Key]attribute, it will be validated (it must be a primitive type) and written in the type metadataforeachbinding and the DOM elements are not recreated