Skip to content

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Nov 19, 2025

This PR supports explicit credentials for Azure connector. Closes https://linear.app/rilldata/issue/APP-394/azure-explicit-credential-flow-for-models

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Nov 19, 2025
@lovincyrus lovincyrus force-pushed the cyrus/azure-explicit-credentials-1 branch from 3bab9f3 to 369d8ec Compare November 21, 2025 06:09
@lovincyrus lovincyrus requested a review from royendo November 21, 2025 06:50
@lovincyrus lovincyrus marked this pull request as ready for review November 21, 2025 06:50
Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior same as s3, will need to add the
create_secrets_from_connectors key when creating model to ensure we're testing with correct connector.

Also, Azure should have three types of connector types

  • Connection String
  • Storage Account Key
  • SAS Token

https://linear.app/rilldata/issue/PLAT-254/support-new-azure-configuration-keys

https://www.figma.com/design/JtG3sbaopjO0xQlyeCjmho/RILL-WIP?node-id=929-91681&t=K9VCihwKY36b4LLN-1

Might need to rebase as this is outputting the raw connector string into the model.yaml again

@lovincyrus lovincyrus force-pushed the cyrus/azure-explicit-credentials-1 branch from 369d8ec to c8bdeba Compare November 24, 2025 09:36
@lovincyrus lovincyrus marked this pull request as draft November 24, 2025 20:30
@lovincyrus lovincyrus removed the request for review from ericpgreen2 November 24, 2025 20:30
@lovincyrus
Copy link
Contributor Author

Latest demo:

CleanShot.2025-11-25.at.17.11.03.mp4

@lovincyrus
Copy link
Contributor Author

Behavior same as s3, will need to add the
create_secrets_from_connectors key when creating model to ensure we're testing with correct connector.

This change will be committed from this PR #8354

@lovincyrus lovincyrus marked this pull request as ready for review November 25, 2025 10:59
@lovincyrus lovincyrus requested a review from royendo November 25, 2025 11:00
Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as s3,

Id pick to not add anything to the YAML for public sources. This makes the logic easier as we wont need to consider "which one should we add?"

A few things i noticed:

it doesnt grab the correct connector_name when multiple connectors
cant see create_secrets_from_connectors in model preview
https://jam.dev/c/5dd636b6-2703-4c58-bd03-c0a6f8c35fbf

but once in lmk and ill do a final review :)

@lovincyrus
Copy link
Contributor Author

cant see create_secrets_from_connectors in model preview
https://jam.dev/c/5dd636b6-2703-4c58-bd03-c0a6f8c35fbf

#8354 (comment)

@lovincyrus
Copy link
Contributor Author

Superseded by #8467

@lovincyrus lovincyrus closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants