-
Notifications
You must be signed in to change notification settings - Fork 159
Azure Explicit Credentials #8357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3bab9f3 to
369d8ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior same as s3, will need to add the
create_secrets_from_connectors key when creating model to ensure we're testing with correct connector.
Also, Azure should have three types of connector types
- Connection String
- Storage Account Key
- SAS Token
https://linear.app/rilldata/issue/PLAT-254/support-new-azure-configuration-keys
https://www.figma.com/design/JtG3sbaopjO0xQlyeCjmho/RILL-WIP?node-id=929-91681&t=K9VCihwKY36b4LLN-1
Might need to rebase as this is outputting the raw connector string into the model.yaml again
369d8ec to
c8bdeba
Compare
|
Latest demo: CleanShot.2025-11-25.at.17.11.03.mp4 |
This change will be committed from this PR #8354 |
royendo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as s3,
Id pick to not add anything to the YAML for public sources. This makes the logic easier as we wont need to consider "which one should we add?"
A few things i noticed:
it doesnt grab the correct connector_name when multiple connectors
cant see create_secrets_from_connectors in model preview
https://jam.dev/c/5dd636b6-2703-4c58-bd03-c0a6f8c35fbf
but once in lmk and ill do a final review :)
|
|
Superseded by #8467 |
This PR supports explicit credentials for Azure connector. Closes https://linear.app/rilldata/issue/APP-394/azure-explicit-credential-flow-for-models
Checklist: