Skip to content

Conversation

@djbarnwal
Copy link
Member

Adds canvas generation option to navigation files

https://www.notion.so/rilldata/E2E-Rill-Developer-AI-UX-Feedback-2c0ba33c8f578007b425d5dac810f21e?source=copy_link#2c4ba33c8f578081a648d2eff32a8e34

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal requested a review from ericokuma January 2, 2026 10:35
Copy link
Contributor

UXQA:

  1. I would use a trash icon instead the 'x' icon for 'delete'

Otherwise, it looks good!

@djbarnwal djbarnwal requested a review from ericpgreen2 January 5, 2026 15:53
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a few minor observations:

  1. Inconsistent "with AI" label treatment: In GoToDashboardButton.svelte, the AI indicator is appended as plain text (Generate Canvas Dashboard with AI), while in ModelMenuItems.svelte, SourceMenuItems.svelte, and MetricsViewMenuItems.svelte it includes a wand icon. Consider using the same visual treatment consistently.

  2. Potential non-functional menu item: In MetricsViewMenuItems.svelte, when hasMenuItems is false, the "View DAG graph" item is still rendered in the else block. The viewGraph() function has a guard that returns early if resource is undefined, so clicking it would do nothing. Consider hiding or disabling this item when there's no resource.

  3. "DAG graph" is redundant: "DAG" expands to "Directed Acyclic Graph", so "DAG graph" means "Directed Acyclic Graph graph". Consider using just "View DAG" or keeping the original "View dependency graph".

None of these are blockers.


Developed in collaboration with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants