Skip to content

Conversation

@ericokuma
Copy link
Contributor

@ericokuma ericokuma commented Jan 6, 2026

Fixes UI inconsistencies in the Add guest users modal.

The project and access level dropdowns now match the height of the email input field for visual alignment. Additionally, the access level selector now uses checkbox items to provide clear visual feedback (checkmarks) for the selected role.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Linear Issue: APP-668

Open in Cursor Open in Web


Note

Improves the AddGuestsDialog UI and selection behavior for guest invites.

  • Updates dropdown trigger styling (min-h 32px, bg-white, text-sm, padding) to visually align with the email input
  • Replaces hardcoded role items with ORG_ROLES_OPTIONS and uses Dropdown.CheckboxItem to show the selected role with a checkmark
  • Keeps the project dropdown open after toggling a project selection; resets now also close both dropdowns

Written by Cursor Bugbot for commit 55222e7. This will update automatically on new commits. Configure here.

Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@cursor
Copy link

cursor bot commented Jan 6, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

cursoragent and others added 2 commits January 6, 2026 16:38
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
Adjusted min-height for dropdown triggers and ensured proper reset of dialog state variables.

Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@ericokuma ericokuma requested a review from AdityaHegde January 6, 2026 17:12
@ericokuma ericokuma marked this pull request as ready for review January 6, 2026 17:12
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great step to user management cleanup using ORG_ROLES_OPTIONS!

Note there is a small lint error. Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants