Open
Conversation
added 2 commits
October 7, 2019 23:58
rilopez
requested changes
Oct 9, 2019
Owner
rilopez
left a comment
rilopez
left a comment
There was a problem hiding this comment.
Please clean up your PR, this is not ready to be reviewed
.idea/$PRODUCT_WORKSPACE_FILE$
Outdated
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Owner
There was a problem hiding this comment.
The .idea files should be ignored
pom.xml
Outdated
| <version>4.7</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
Owner
There was a problem hiding this comment.
Why are you making this empty line change?
| contador++; | ||
| } | ||
| }catch (IndexOutOfBoundsException ioub){ | ||
| // System.out.println("LLEGO VACIO EXCEPTION"); |
Owner
There was a problem hiding this comment.
you need to remove this comment and handle the exception
|
|
||
|
|
||
| int getTotalReviews(String archivo) throws FileNotFoundException, IOException { | ||
| String cadena; |
Owner
There was a problem hiding this comment.
please do not mix spanish and english
| char slash; | ||
| char u; | ||
| int contador = 0; | ||
| //char e; |
Owner
There was a problem hiding this comment.
a comment is not a way to temporally remove code, please use git instead
added 6 commits
October 9, 2019 13:08
…ews as well as for sending recommendations to a specific user
lromero21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The movie recommender, all test successful