chore(scripts): add --reuse-engine & validate provided engine version

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
rivet-cloud	Ignored		Dec 29, 2025 7:41pm
rivet-inspector	Ignored	Preview	Dec 29, 2025 7:41pm
rivet-site	Ignored	Preview	Dec 29, 2025 7:41pm
rivetkit-serverless	Skipped		Dec 29, 2025 7:41pm

[NathanFlurry]

• chore(scripts): add --reuse-engine & validate provided engine version #3718 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review - PR #3718

This PR adds two new features to the release script:

1. --reuse-engine flag to automatically find and reuse the most recent version with engine artifacts
2. Validation to ensure a version hasn't already been published before proceeding

Strengths

1. Good refactoring: The extraction of getAwsCredentials() and checkEngineArtifactsExist() into separate functions improves code organization and reusability.

2. Better error handling: The new EngineArtifactsResult interface provides structured error information, making debugging easier.

3. Useful feature: The --reuse-engine flag is a practical addition that automates what was previously a manual process.

4. Early validation: Adding validate-version-not-published as an early step prevents wasted work.

Potential Issues

1. Performance concern in findLatestEngineVersion() (lines 232-241):

   • This function checks versions sequentially, making Docker manifest and S3 API calls for each version
   • For repositories with many versions, this could be very slow
   • Recommendation: Consider adding a limit (e.g., only check the last 10-20 versions) or add a timeout/max-check parameter

2. Error information loss (line 210):

   • When catching S3 check errors, the error object is coerced to string
   • This loses stack traces and detailed error information
   • Recommendation: Consider logging the full error object or using error.message

3. Inconsistent stdio handling (lines 174-175, 200):

   • Docker manifest calls use default stdio (which may output to console)
   • S3 calls explicitly set stdio: ["pipe", "pipe", "pipe"]
   • In non-verbose mode, Docker errors may still print to stderr
   • Recommendation: For consistency, consider piping all stdio in checkEngineArtifactsExist when verbose = false

Security

No security concerns identified. The AWS credentials are properly handled through environment variables or 1Password.

Performance

• Sequential Docker/S3 checks: As mentioned above, findLatestEngineVersion() could be slow with many versions
• Consider adding progress indicators or parallel checking (though parallel Docker manifest inspects might hit rate limits)

Code Quality

1. Good TypeScript practices: Proper typing with interfaces and return types
2. Clear variable names: shortCommit, reuseEngineVersion, etc. are descriptive
3. Helpful console output: The progress messages are clear and informative

Suggestions

1. Add a retry mechanism: Docker manifest checks and S3 API calls could fail due to network issues. Consider adding retries for transient failures.

2. Cache optimization: In findLatestEngineVersion(), if checking many versions, consider caching the AWS credentials fetch (currently called for each version's S3 check).

3. Documentation: Consider adding comments explaining why both Docker images AND S3 artifacts are required for a version to be considered valid.

Minor Issues

1. Line 518: Comment says "8 char" but checks for length 7 - should be "7 char short commit"

Verdict

This is a solid PR that adds useful functionality with good code organization. The main concerns are:

• Performance of sequential version checking in findLatestEngineVersion()
• Missing error handling for transient network failures

Recommendation: Approve with minor changes. Consider adding a version check limit to prevent excessive API calls.

---

Review generated with assistance from Claude Code

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-next-js
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-deno
• example-sqlite
• example-elysia
• example-experimental-durable-streams-ai-agent
• example-express
• example-hono
• hono-bun
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• example-node
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3718

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3718

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3718

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3718

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3718

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3718

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3718

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3718

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3718

commit: c900c54