Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/docker/template/grafana-dashboards/gasoline.json
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@
"uid": "prometheus"
},
"editorMode": "code",
"expr": "count by (rivet_datacenter) ((time() - timestamp(rivet_gasoline_worker_last_ping{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"}) < 30)) ",
"expr": "count by (rivet_datacenter) ((time() - rivet_gasoline_worker_last_ping{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"} / 1000) < 30)",
"instant": false,
"legendFormat": "__auto",
"range": true,
Expand Down
1 change: 1 addition & 0 deletions engine/packages/config/src/config/runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use schemars::JsonSchema;
use serde::{Deserialize, Serialize};

#[derive(Debug, Clone, Serialize, Deserialize, Default, JsonSchema)]
#[serde(deny_unknown_fields)]
pub struct Runtime {
/// Adjusts worker curve around this value (in millicores, i.e. 1000 = 1 core). Is not a hard limit. When
/// unset, uses /sys/fs/cgroup/cpu.max, and if that is unset uses total host cpu.
Expand Down
1 change: 1 addition & 0 deletions engine/packages/config/src/config/telemetry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use schemars::JsonSchema;
use serde::{Deserialize, Serialize};

#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
#[serde(deny_unknown_fields)]
pub struct Telemetry {
pub enabled: bool,
}
Expand Down
4 changes: 1 addition & 3 deletions engine/packages/guard-core/src/proxy_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2288,9 +2288,7 @@ impl ProxyService {
// Keep TCP connection open briefly to allow client to process close
tokio::time::sleep(WEBSOCKET_CLOSE_LINGER).await;
}
.instrument(
tracing::info_span!("ws_error_proxy_task", ?request_ids.ray_id),
),
.instrument(tracing::info_span!("ws_error_proxy_task")),
);

// Return the response that will upgrade the client connection
Expand Down
9 changes: 3 additions & 6 deletions engine/packages/pegboard/src/workflows/actor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
async move {
let signals = if let Some(gc_timeout_ts) = state.gc_timeout_ts {
// Listen for signals with gc timeout. if a timeout happens, it means this actor is lost
let signals = ctx.listen_n_until::<Main>(gc_timeout_ts, 1024).await?;
let signals = ctx.listen_n_until::<Main>(gc_timeout_ts, 256).await?;
if signals.is_empty() {
tracing::warn!(actor_id=?input.actor_id, "actor lost");

Expand All @@ -292,7 +292,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
} else if let Some(alarm_ts) = state.alarm_ts {
// Listen for signals with timeout. if a timeout happens, it means this actor should
// wake up
let signals = ctx.listen_n_until::<Main>(alarm_ts, 1024).await?;
let signals = ctx.listen_n_until::<Main>(alarm_ts, 256).await?;
if signals.is_empty() {
tracing::debug!(actor_id=?input.actor_id, "actor wake");

Expand All @@ -307,7 +307,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
}
} else {
// Listen for signals normally
ctx.listen_n::<Main>(1024).await?
ctx.listen_n::<Main>(256).await?
};

for sig in signals {
Expand Down Expand Up @@ -824,9 +824,6 @@ async fn handle_stopped(
})
.await?;

// NOTE: The reason we allocate other actors from this actor workflow is because if we instead sent a
// signal to the runner wf here it would incur a heavy throughput hit and we need the runner wf to be as
// lightweight as possible; processing as few signals that aren't events/commands.
// Allocate other pending actors from queue since a slot has now cleared
let allocate_pending_res = ctx
.activity(AllocatePendingActorsInput {
Expand Down
Loading