fix: show reset datetime in tooltip#253
Merged
validatedev merged 4 commits intorobinebers:mainfrom Mar 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/provider-card.test.tsx">
<violation number="1" location="src/components/provider-card.test.tsx:264">
P2: Duplicated formatting logic: `formatResetTooltipText` is already imported but not used here. This inline `Intl.DateTimeFormat` construction mirrors the implementation in `src/lib/reset-tooltip.ts` verbatim, creating a maintenance burden. If the format changes, this test must be updated independently. Use the imported function for consistency (as done in the toggle test at line 416).</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Owner
|
Hi Wooram, Thank you for your contribution. Would love to see screenshots to understand what the before and after is. |
Contributor
Author
davidarny
approved these changes
Mar 1, 2026
Collaborator
davidarny
left a comment
There was a problem hiding this comment.
I fixed P2 and removed screenshots from the docs/ folder. Otherwise, looks clean, thanks!
validatedev
approved these changes
Mar 1, 2026
Collaborator
validatedev
left a comment
There was a problem hiding this comment.
Looks clean, no issues! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Testing
Before / After
Closes #108
Summary by cubic
Show the exact next reset date/time in provider card tooltips so users can verify the next reset moment. Preserves existing labels and toggle behavior; closes #108.
Written for commit 2f89185. Summary will update on new commits.