Fix: Warning issue due to the conditional testing of multiple elements related to the barrier argument#3
Open
pedrohbraga wants to merge 1 commit intorobinengler:masterfrom
Open
Conversation
…ments within the barrier argument The `if(barrier!="")` testing outputs a warning issue when an object with more than one element is provided, which is often the case for this argument. I did not test whether this issue would cause a problem in the results, but it did not seem to be a big issue. In this pull-request, I have replaced `if(barrier!="")` by `if(!identical(barrier, ""))`, which does the test originally intended (whether the barrier object is different than an empty string), without producing a warning related to conditional testing on multiple elements. The function worked well on both example data tests and on a separate empirical test dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
if(barrier!="")testing outputs a warning issue when an object with more than one element is provided, which is often the case for this argument.I described these warnings with a reproducible example within issue #2.
I did not test whether this issue would cause a problem in the results, but it did not seem to be a big issue.
In this pull-request, I have replaced
if(barrier!="")byif(!identical(barrier, "")), which does the test originally intended (whether the barrier object is different than an empty string), without producing a warning related to conditional testing on multiple elements.The function worked well on both example data tests and on a separate empirical test dataset.