Phase 2: Add properties to EAGL.Node, preserve glTF extras at bridge#2
Merged
robinhilliard merged 1 commit intomainfrom Mar 3, 2026
Merged
Phase 2: Add properties to EAGL.Node, preserve glTF extras at bridge#2robinhilliard merged 1 commit intomainfrom
robinhilliard merged 1 commit intomainfrom
Conversation
- 2.1: Add properties field to EAGL.Node struct, new/1, with_matrix/2 - 2.2: Pass gltf_node.extras through as properties in node_to_eagl_node - glTF.Node keeps 'extras' (spec); EAGL.Node uses 'properties' (domain term) - Add tests for properties preservation Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk additive change: introduces an optional
propertiesfield onEAGL.Nodeand threads glTFextrasthrough the bridge; existing node creation paths are only extended with a new optional key.Overview
Preserves per-node custom metadata when importing glTF.
EAGL.Nodegains an optionalpropertiesmap field, and bothNode.new/1andNode.with_matrix/2accept:properties.The glTF→EAGL bridge (
node_to_eagl_node/4) now passesgltf_node.extrasintoEAGL.Node.propertiesfor both TRS and matrix nodes, with new tests asserting extras are preserved (ornilwhen absent).Written by Cursor Bugbot for commit 5e9cf55. This will update automatically on new commits. Configure here.