-
-
Notifications
You must be signed in to change notification settings - Fork 18
Add data-testid attributes for test automation #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
|
|
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
|
@copilot remove package.lock, we use yarn |
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
|
@copilot rollback all changes to yarn.lock as well |
Co-authored-by: gugu <75169+gugu@users.noreply.github.com>
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR addresses the request to add data-testid attributes to specific UI elements to improve test automation capabilities.
Changes Made
Verified Existing Implementation:
data-testid="company-name"already exists inconnections-list.component.htmldata-testid="table-paginator"already exists indb-table.component.htmlAdditional Enhancement:
data-testid="audit-paginator"to the audit component's paginator for consistency across similar componentsFindings
The main testids requested in the issue were already properly implemented in the codebase:
Company name display: Located in
/frontend/src/app/components/connections-list/connections-list.component.htmlline 5Table pagination: Located in
/frontend/src/app/components/dashboard/db-table/db-table.component.htmlline 380The requested data-testid attributes were already in place, suggesting this issue may have been resolved in a previous commit. I've added an additional testid for the audit paginator to maintain consistency across similar UI components.
Testing
Fixes #1143.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.ionode install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.