Devnet 5 Legacy RPL Stake interface changes #952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for interface updates targeting this commit: rocket-pool/rocketpool@898af10
New file
/v1.3.1/protocol/node.gofor legacy bindings for commands being removed in Saturn:getMinimumPerMinipoolStakeandgetMaximumPerMinipoolStake.Bindings for the new calls
getMinimumLegacyRPLStakeandgetNodeMinimumLegacyRPLStakeRemoved
getNodeMaximumRPLStakeForMinipoolsfrom bindings, as it no longer exists inrp:1.4. Houston usesgetNodeMaximumRPLStaketo fetch the amount of RPL that a node can withdraw down to. The new command is calledgetNodeMinimumLegacyRPLStake.In previous versions of Rocket Pool, the field used to represent the amount of RPL that a node can withdraw down to was called
MaximumRplStake. In Saturn, the same field is now calledMinimumLegacyRPLStake. It's a bit confusing. The SN needs to support the Houston1.3.1interface on top of1.4, so I've used the variable namesRplStakeThresholdandRplStakeThresholdFractionacross the SN to represent the amount of RPL that a node can withdraw down to.Added pdao command to propose the new setting
node.minimum.legacy.staked.rpl.Updated
get-settingsapi and cli to support the new settings.Wrapped the deprecated settings (
node.per.minipool.stake.minimumandnode.per.minipool.stake.maximum) inside a check to ensure they aren't accessible when saturn is deployed.Deleted unused code in
node-statusapi:response.MinimumRplStake, response.PendingMinimumRplStake, response.PendingMaximumRplStake, response.MinimumRplStake.New information displayed in
node statuscli