Conversation
…eoCardExpand, VideoCardGrid, VideoSuggestionsCard, Context for liked/history/watchLater
…and fixed: warnings by adding key to every mapping
sandeepmehta2155
left a comment
sandeepmehta2155
left a comment
There was a problem hiding this comment.
Amazing UI and very clean View
src/App.js
Outdated
| @@ -1,11 +1,109 @@ | |||
| import './App.css'; | |||
| import { Routes, Route } from "react-router-dom"; | |||
| import CategoryScroller from "./components/CategoryScroller/CategoryScroller"; | |||
There was a problem hiding this comment.
In app.js import files from index.js to make code look clean
| <> | ||
| {state.watchLaterArr.length === 0 ? ( | ||
| <NoVideosFoundPage /> | ||
| ) : ( |
There was a problem hiding this comment.
Can use switch case but it's ok as logic is small
There was a problem hiding this comment.
As there are only two things, i think ternary operator is fine
| }, | ||
| { | ||
| topic: "DataScience", | ||
| id: uuid(), |
There was a problem hiding this comment.
When data is reloaded, this might get change & effect your data updation
There was a problem hiding this comment.
This id is only used for passing in the key prop of categories, it wouldn't make a diffrence
src/components/NavBar/NavBar.js
Outdated
| dispatch({type: "SEARCH_VIDEOS", payload: inputVal}) | ||
| navigate(`/search?q=${inputVal}`); | ||
| }}> | ||
| <span role="img">🔍</span> |
sandeepmehta2155
left a comment
sandeepmehta2155
left a comment
There was a problem hiding this comment.
Things had been reviewed, wishing all the best ahead
|
Hey Rohan,
|
… fixed page going blank on empty search
…osition to category scroller
|
shubham-ghuge
left a comment
shubham-ghuge
left a comment
There was a problem hiding this comment.
Thank you for considering the changes Rohan,
I'm approving the PR.
Removed backend, will add that on separate branch so that i dont mess up my front end
3 participants
No description provided.