Open
Conversation
pull from master 1
pull from master
merdge 5
Author
|
не особо разобрался как стоит сделать правильную выборку из статей комментариев, я их туда смог запихнуть, но вот сделать правильную выборку, через селектор пока не понял как |
romabelka
reviewed
Feb 8, 2018
| const body = comments.length ? ( | ||
| <ul> | ||
| {comments.map(id => <li key = {id}><Comment id = {id} /></li>)} | ||
| {comments.map(comment => <li key = {comment['id']}><Comment id = {comment['id']} /></li>)} |
Owner
There was a problem hiding this comment.
вот этого хода я совсем не осознал) зачем доставать id из коммента, чтоб потом по нему снова найти этот коммент из стора?
| console.log(payload.response) | ||
| return comments | ||
| .set('loading', false) | ||
| .set('loaded', true) |
Owner
There was a problem hiding this comment.
Почему loaded === true, ведь ты загрузил только для одной статьи?
| })) | ||
|
|
||
| case LOAD_COMMENT + START: | ||
| return comments.set('loading', true) |
Owner
There was a problem hiding this comment.
здесь не достаточно повесить loading на весь comments, ведь ты для конкрентной статьи загружаешь
| return comments | ||
| .set('loading', false) | ||
| .set('loaded', true) | ||
| .set('entities', arrToMap(payload.response, CommentsRecord)) |
Owner
There was a problem hiding this comment.
сейчас загружая комменты для одной статьи ты перезатираешь прошлые; используй .mergeIn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.