-
Notifications
You must be signed in to change notification settings - Fork 14
Hometask 06 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tursumbekov
wants to merge
9
commits into
romabelka:master
Choose a base branch
from
tursumbekov:hometask_06
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hometask 06 #84
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
96c93f1
Merge pull request #1 from romabelka/master
tursumbekov e0a94b4
Merge pull request #2 from romabelka/master
tursumbekov 341ede3
Merge pull request #3 from romabelka/master
tursumbekov f353bf2
Merge pull request #4 from romabelka/master
tursumbekov ba2733b
Merge pull request #5 from romabelka/master
tursumbekov 1f536dc
Merge pull request #6 from romabelka/master
tursumbekov 326d9d6
Hometask_06
tursumbekov b50bc9f
Fix
tursumbekov 9d41b55
Fix
tursumbekov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,46 @@ | ||
| import { ADD_COMMENT } from '../constants' | ||
| import {normalizedComments} from '../fixtures' | ||
| import { Map, Record } from 'immutable' | ||
| import { ADD_COMMENT, LOAD_COMMENTS, START, SUCCESS, FAIL } from '../constants' | ||
| import {arrToMap} from './utils' | ||
|
|
||
| export default (state = arrToMap(normalizedComments), action) => { | ||
| const { type, payload, randomId } = action | ||
| const CommentsRecord = Record({ | ||
| id: null, | ||
| user: null, | ||
| text: null | ||
| }) | ||
|
|
||
| const ReducerRecord = Record({ | ||
| entities: arrToMap([], CommentsRecord), | ||
| loading: false, | ||
| loaded: false, | ||
| error: null, | ||
| //cache: false, | ||
| loadedId: null | ||
| }) | ||
|
|
||
| export default (state = new ReducerRecord(), action) => { | ||
| const { type, payload, randomId, error } = action | ||
|
|
||
| switch (type) { | ||
| case ADD_COMMENT: | ||
| return state.set(randomId, { | ||
| ...payload.comment, | ||
| id: randomId | ||
| }) | ||
| return state.setIn(['entities', randomId], | ||
| new CommentsRecord({ ...payload.comment, id: randomId})) | ||
|
|
||
| case LOAD_COMMENTS + START: | ||
| return state | ||
| .set('loading', true) | ||
| .set('loadedId', payload.id) | ||
|
|
||
| case LOAD_COMMENTS + FAIL: | ||
| return state | ||
| .set('loading', false) | ||
| .set('error', error) | ||
|
|
||
| case LOAD_COMMENTS + SUCCESS: | ||
| return state | ||
| .set('loading', false) | ||
| .set('loaded', true) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Почему loaded === true, ведь ты загрузил только для одной статьи? |
||
| //.set('cache', true) | ||
| .set('entities', arrToMap(payload.response, CommentsRecord)) | ||
| } | ||
|
|
||
| return state | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
здесь не достаточно повесить loading на весь comments, ведь ты для конкрентной статьи загружаешь