-
Notifications
You must be signed in to change notification settings - Fork 14
Hometask 8 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0ro
wants to merge
11
commits into
romabelka:master
Choose a base branch
from
0ro:hometask_8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hometask 8 #90
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0f2c95f
Merge remote-tracking branch 'romabelka/master'
c0e6bf3
Merge remote-tracking branch 'romabelka/master'
f46ac83
Merge remote-tracking branch 'romabelka/master'
0d15db6
Merge remote-tracking branch 'romabelka/master'
e2605a5
Merge remote-tracking branch 'romabelka/master'
62afaba
Merge remote-tracking branch 'romabelka/master'
d142f87
Merge remote-tracking branch 'romabelka/master'
87c68c8
Merge remote-tracking branch 'romabelka/master'
4ff6c2f
Merge remote-tracking branch 'romabelka/master'
f34f714
Add dictionary
d07f747
Fix article bug
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React, { Component } from 'react' | ||
| import PropTypes from 'prop-types' | ||
| import App from './App' | ||
| import dictionary from '../dictionary' | ||
|
|
||
| class Root extends Component { | ||
| static childContextTypes = { | ||
| dictionary: PropTypes.object | ||
| } | ||
|
|
||
| getChildContext() { | ||
| return { | ||
| dictionary | ||
| } | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <div> | ||
| <App/> | ||
| </div> | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| export default Root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| import React from 'react' | ||
| import PropTypes from 'prop-types' | ||
|
|
||
| function Loader(props) { | ||
| function Loader(props, {dictionary}) { | ||
| return ( | ||
| <h2>Loading...</h2> | ||
| <h2>{dictionary.Loading}...</h2> | ||
| ) | ||
| } | ||
|
|
||
| Loader.propTypes = { | ||
| } | ||
|
|
||
| Loader.contextTypes = { | ||
| dictionary: PropTypes.object | ||
| } | ||
|
|
||
| export default Loader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| export default { | ||
| 'App_name': 'Название приложения', | ||
| 'Articles': 'Статьи', | ||
| 'Filters': 'Фильтры', | ||
| 'Counter': 'Счетчик', | ||
| 'Comments': 'Комментарии', | ||
| 'Add_new_Article_form': 'Добавить новую статью', | ||
| 'Error_page': 'Ошбика', | ||
| 'Nor_found': 'Не найдено', | ||
| 'Main_menu': 'Главное меню', | ||
| 'Username': 'Имя пользователя', | ||
| 'No_Articles': 'Нет статей', | ||
| 'Article_list': 'Список статей', | ||
| 'Please_select_an_article': 'Пожалуйста, выберите статью', | ||
| 'Loading': 'Загрузка', | ||
| 'User': 'Пользователь', | ||
| 'No_comments_yet': 'Пока нет комментариев', | ||
| 'hide_comments': 'скрыть комментарии', | ||
| 'show_comments': 'показать комметарии', | ||
| 'close': 'закрыть', | ||
| 'open': 'открыть', | ||
| 'delete': 'удалить' | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,16 @@ | ||
| import React from 'react' | ||
| import {render} from 'react-dom' | ||
| import {Provider} from 'react-redux' | ||
| import App from './components/App' | ||
| import Root from './components/Root' | ||
| import {ConnectedRouter} from 'react-router-redux' | ||
| //import {HashRouter, BrowserRouter} from 'react-router-dom' | ||
| import store from './store' | ||
| import history from './history' | ||
|
|
||
|
|
||
|
|
||
| render(<Provider store = {store}> | ||
| <ConnectedRouter history = {history}> | ||
| <App/> | ||
| <Root/> | ||
| </ConnectedRouter> | ||
| </Provider>, document.getElementById('container')) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут и в других местах: лучше сделай декоратор либо компонент-обертку для локализации, чтоб не обращатся каждый раз к контексту, иначе потом тяжело будет что-либо поменять