-
Notifications
You must be signed in to change notification settings - Fork 7
New api CMXUMS and CMXKND enhancements #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iaddict
wants to merge
7
commits into
romanblick:master
Choose a base branch
from
iaddict:new-api-cmxums
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
45d0211
+ added new api for revenues: CMXUMS
iaddict b6053d1
* added missing sepa fields for api CMXKND
iaddict 37c607c
* renamed all field names for CMXUMS to start with index of api
iaddict f81515d
Update gem to work with ruby 3.x
iaddict 8ad371c
Bump version
iaddict aba7fd5
Convert deprecated specs syntax
iaddict 3176b9b
Add std lib gems
iaddict File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| class Collmex::Api::Cmxums < Collmex::Api::Line | ||
| def self.specification | ||
| [ | ||
| { name: :_1_identifyer, type: :string, fix: "CMXUMS"}, # 1 | ||
| { name: :_2_customer_id, type: :integer}, | ||
| { name: :_3_company_id, type: :integer, default: 1}, | ||
| { name: :_4_receipt_date, type: :date }, | ||
| { name: :_5_receipt_number, type: :string }, # 5 | ||
| { name: :_6_net_value_full_tax, type: :currency }, | ||
| { name: :_7_tax_value_full_tax, type: :currency }, | ||
| { name: :_8_net_value_half_tax, type: :currency }, | ||
| { name: :_9_tax_value_half_tax, type: :currency }, | ||
| { name: :_10_net_value_inter_eu_trade, type: :currency }, # 10 | ||
| { name: :_11_net_value_export, type: :currency }, | ||
| { name: :_12_account_revenue_tax_free, type: :integer }, | ||
| { name: :_13_value_revenue_tax_free, type: :currency }, | ||
| { name: :_14_currency_code, type: :string }, | ||
| { name: :_15_contra_account, type: :integer }, # 15 | ||
| { name: :_16_receipt_type, type: :integer, default: 0 }, | ||
| { name: :_17_receipt_text, type: :string }, | ||
| { name: :_18_payment_term, type: :integer }, | ||
| { name: :_19_account_full_tax, type: :integer }, | ||
| { name: :_20_account_half_tax, type: :integer }, # 20 | ||
| { name: :_21_reserved21, type: :string }, | ||
| { name: :_22_reserved22, type: :string }, | ||
| { name: :_23_storno, type: :integer }, | ||
| { name: :_24_final_receipt, type: :string }, | ||
| { name: :_25_revenue_type, type: :integer }, # 25 | ||
| { name: :_26_system_name, type: :string }, | ||
| { name: :_27_charge_against_receipt_number, type: :string }, | ||
| { name: :_28_cost_center, type: :string } | ||
| ] | ||
| end | ||
| end | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit odd to me to prefix the hash keys with numbers. At least this is not the current practice in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well - yes when looking at it it looks odd - but when I implemented the api and I looked at the API documentation at collmex it was super hard to find the matching fields (translate to german and find the right position).
The API is CSV based and thus the index is the most important criteria to feed it right.
When using the ruby API it gets so much easier to find and use the right fields. It just feels better to have the index in place and to be safe when using the API. The descriptive name makes it then just easier to read.