Adding support for string version of :lein-v in project.clj#24
Open
timgilbert wants to merge 1 commit intoroomkey:masterfrom
Open
Adding support for string version of :lein-v in project.clj#24timgilbert wants to merge 1 commit intoroomkey:masterfrom
timgilbert wants to merge 1 commit intoroomkey:masterfrom
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Sorry to inundate you with pull requests. This is a small one that lets the user specify the version in project.clj either the keyword
:lein-v(the existing behavior) or the string":lein-v". The reason for this is that Cursive currently crashes when trying to import projects with their version numbers set to keywords.I filed a bug on the Cursive repo about the crashing issue, but I wouldn't be surprised if other tools that parse project.clj files from outside of leiningen also expect the version number to be a string, so it seems reasonable to support both
:lein-vand":lein-v".