Small Refactoring of Plugin #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Administrator user group by default
…code readability like that + catching wrong system events
…y (OnSiteRefresh event)
Owner
|
Thanks for this @exside! I'm actually really close to getting the new version of ElementHelper into a releasable state. The new version has tidied up things a lot and will make the code much easier to work with (I hope!). I'll make an effort to get it up on a new branch in the next day or so with a list of things that are still left to do that I'd appreciate any help on. |
Contributor
Author
|
Sure, would love to have a look at =), let me know when the branch is up via comment here (then I get notified), yes? |
Owner
|
The branch is up now! (it's called 2.0) and I've started a new thread for it here #31 with a link to a working package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing essential changed, basically preparing for bigger PRs coming (trying to split up #16).
Adding functionality that clears the element helper cache when the cache is manually cleared by a member of an authorized user group via Top Menu > Clear Cache.
The big line changes in the main part of the plugin are not changes, it's just the indenting because of the switch statement! Nothing changed in the functionality!!
Integrated also the deprecated $modx->getMicrotime() fix from #29
Following PRs will be based on this branch, so please merge this, then I can rebase my other branches with the new master of your repo, will make seeing changes easier!