Merged
Conversation
mabelzhang
reviewed
Feb 5, 2021
Contributor
There was a problem hiding this comment.
Thanks for the PR. The setMinimumSize(1,1) gets rid of the numpy.linalg.linalg.LinAlgError: Singular matrix error when I did the steps in #54. But the safe_tight_layout is still needed on my system, otherwise rqt_plot crashed right away.
That's a cleaner way to resolve ros-visualization#35 and ros-visualization#54.
rhaschke
force-pushed
the
fix-resize-bug
branch
from
9482157 to
de4129b
Compare
Contributor
Author
|
Sorry, I tested only on Noetic, where the matplotlib issue is already fixed natively. I removed the reversion of #52 from this PR now. |
mabelzhang
approved these changes
Feb 6, 2021
Contributor
mabelzhang
left a comment
mabelzhang
left a comment
There was a problem hiding this comment.
This works. I tested on Kinetic, Melodic, and Noetic. Kinetic and Melodic are clean. Noetic has a warning but no crashes.
For future reference, the warning on Kinetic is
/home/developer/viper/catkin_ws/install_isolated/lib/python3/dist-packages/rqt_plot/data_plot/mat_data_plot.py:122: UserWarning: Tight layout not applied. The bottom and top margins cannot be made large enough to accommodate all axes decorations.
self.figure.tight_layout()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
reverts #52 and instead justsets the minimum canvas size to (1,1), which avoids the bugs mentioned in #35 and #54.This PR takes a similar approach as #56 (which targets the ros2 branch) but sets the minimum size of the canvas widget.