Skip to content

Conversation

@markspolakovs
Copy link
Contributor

No description provided.

@ashhhleyyy
Copy link
Collaborator

could this fall back to generating from DB for complete streams that aren't in redis (so state == Complete && !(await redis.sIsMember('complete_streams', id))

@ashhhleyyy
Copy link
Collaborator

otherwise seems good, will test locally in a bit

@markspolakovs
Copy link
Contributor Author

could this fall back to generating from DB for complete streams that aren't in redis (so state == Complete && !(await redis.sIsMember('complete_streams', id))

Problem is we don't know it's complete without consulting the DB - could make the logic if (!isInRedis) { fetchFromDB; if (isComplete) … }

@ashhhleyyy
Copy link
Collaborator

yeah that would probably work; I'm mostly cautious about breaking all the catchup streams lol

@markspolakovs
Copy link
Contributor Author

done that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants