Skip to content

Manual login option #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loxK wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Manual login option #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2fec4
feat(admin): add allow manual login option
loxK Feb 4, 2026
33d1542
Merge branch 'rotdrop:master' into manual-login-option
loxK Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Controller/PageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,13 @@ public function index()
$reason = null;

$roundCubeUrl = $this->authenticator->externalURL();
$allowManualLogin = $this->config->getAppValue(Config::ALLOW_MANUAL_LOGIN);
$credentials = null;
if (empty($roundCubeUrl)) {
$state = self::ERROR_STATE;
$reason = self::ERROR_NORCURL_REASON;
} else {
} elseif (!$allowManualLogin) {
// Only check credentials if manual login is not allowed
$credentials = $this->config->emailCredentials();
if (empty($credentials)) {
$state = self::ERROR_STATE;
Expand Down
3 changes: 3 additions & 0 deletions lib/Controller/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class SettingsController extends Controller
Config::ENABLE_SSL_VERIFY => [ 'rw' => true, 'default' => Config::ENABLE_SSL_VERIFY_DEFAULT, ],
Config::PERSONAL_ENCRYPTION => [ 'rw' => true, 'default' => Config::PERSONAL_ENCRYPTION_DEFAULT, ],
Config::CARDDAV_PROVISIONG_TAG => [ 'rw' => true, 'default' => Config::CARDDAV_PROVISIONG_TAG_DEFAULT, ],
Config::ALLOW_MANUAL_LOGIN => [ 'rw' => true, 'default' => Config::ALLOW_MANUAL_LOGIN_DEFAULT, ],
];

public const EMAIL_ADDRESS = 'emailAddress';
Expand Down Expand Up @@ -162,6 +163,7 @@ public function setAdmin(string $setting, mixed $value, bool $force = false):Dat
case Config::SHOW_TOP_LINE:
case Config::ENABLE_SSL_VERIFY:
case Config::PERSONAL_ENCRYPTION:
case Config::ALLOW_MANUAL_LOGIN:
$newValue = filter_var($value, FILTER_VALIDATE_BOOLEAN, ['flags' => FILTER_NULL_ON_FAILURE]);
if ($newValue === null) {
return self::grumble($this->l->t(
Expand Down Expand Up @@ -249,6 +251,7 @@ public function getAdmin(?string $setting = null):DataResponse
case Config::SHOW_TOP_LINE:
case Config::ENABLE_SSL_VERIFY:
case Config::PERSONAL_ENCRYPTION:
case Config::ALLOW_MANUAL_LOGIN:
if ($humanValue !== null) {
$humanValue = $humanValue ? $this->l->t('true') : $this->l->t('false');
}
Expand Down
3 changes: 3 additions & 0 deletions lib/Service/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ class Config
public const PERSONAL_ENCRYPTION_DEFAULT = false;
public const CARDDAV_PROVISIONG_TAG = 'cardDavProvisioningTag';
public const CARDDAV_PROVISIONG_TAG_DEFAULT = '';
public const ALLOW_MANUAL_LOGIN = 'allowManualLogin';
public const ALLOW_MANUAL_LOGIN_DEFAULT = false;

const SETTINGS = [
self::EXTERNAL_LOCATION => self::EXTERNAL_LOCATION_DEFAULT,
Expand All @@ -80,6 +82,7 @@ class Config
self::ENABLE_SSL_VERIFY => self::ENABLE_SSL_VERIFY_DEFAULT,
self::PERSONAL_ENCRYPTION => self::PERSONAL_ENCRYPTION_DEFAULT,
self::CARDDAV_PROVISIONG_TAG => self::CARDDAV_PROVISIONG_TAG_DEFAULT,
self::ALLOW_MANUAL_LOGIN => self::ALLOW_MANUAL_LOGIN_DEFAULT,
];

/** @var \OCP\IUser */
Expand Down
15 changes: 15 additions & 0 deletions src/AdminSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,20 @@
<label for="show-top-line">
{{ t(appName, 'Show RoundCube top information bar (shows logout button).') }}
</label>
<input id="allow-manual-login"
v-model="settings.allowManualLogin"
class="checkbox"
type="checkbox"
name="allowManualLogin"
value="1"
:disabled="loading"
@change="saveSetting('allowManualLogin')"
>
<label for="allow-manual-login"
:title="t(appName, 'Allow users to login manually to RoundCube without pre-configured credentials. Useful for shared mailboxes or when SSO is not available.')"
>
{{ t(appName, 'Allow manual RoundCube login (skip credential check).') }}
</label>
<input id="enable-ssl-verify"
v-model="settings.enableSSLVerify"
class="checkbox"
Expand Down Expand Up @@ -265,6 +279,7 @@ const settings = reactive({
fixedSingleEmailPassword: '',
forceSSO: false,
showTopLine: false,
allowManualLogin: false,
enableSSLVerify: true,
personalEncryption: false,
cardDavProvisioningTag: '',
Expand Down