Fixes the long-standing shiny modules problem #127
Conversation
|
@schloerke , we discussed this a long time ago. |
|
Sounds like solving this took a deep dive into the way shiny modules work to find the incompatibility. Thank you @andrie & @schloerke for sticking with this one long enough to resolve it! |
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
Sorry for the delay. I'd rather have it take a different approach. See below.
Q: Are there reasons to not rip the band-aid here?
| packageStartupMessage( | ||
| # rlang::inform("This message will appear only once per session.", .frequency = "once", .frequency_id = "sortable"), | ||
| rlang::inform( | ||
| cli::cli_text("To use sortable with shiny modules, run {.run sortable::enable_modules()} to opt into the new standard."), | ||
| .frequency = "once", | ||
| .frequency_id = "sortable" | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I believe this constant messaging and inconsistent behavior is harder to understand than a big "BREAKING CHANGE, all your sortable DOM IDs have been updated. <previous_format> is now <new_format>. You only need to worry if you have custom css. Thank you for your patience as we have learned from our mistakes." in the NEWS.md
This would remove the startup message, remove the sortable_env, remove the vignette for inconsistent behavior.
I'd rather lean towards "at version X, the behavior changed to something simple and expected".
Fixes #100