Fix/dart sass deprecation #2228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Sass codebase from the deprecated @import directive to the modern @use module system to ensure compatibility with Dart Sass 3.0.0, which will remove support for @import. The migration includes:
- Replacing
@importwith@usedirectives across all SCSS files - Using namespaced imports (e.g.,
@use "variables" as *;for global access) - Replacing deprecated global Sass functions with namespaced module functions (
list.length(),list.nth(),color.adjust()) - Updating CSS output files with properly formatted values (quoted strings, decimal numbers)
Reviewed changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/assets/css/sass/rtmedia.scss | Converted all @import statements to @use, using wildcard namespace for variables |
| app/assets/css/sass/_variables.scss | Added sass:list module import and namespaced list functions |
| app/assets/css/sass/_utility.scss | Added module imports and used namespaced list.length() and list.nth() functions |
| app/assets/css/sass/_tabs.scss | Added variables import with wildcard namespace |
| app/assets/css/sass/_rtm.scss | Added variables import with wildcard namespace |
| app/assets/css/sass/_responsive.scss | Added imports with namespaced utility module access |
| app/assets/css/sass/_popup.scss | Added variables import with wildcard namespace |
| app/assets/css/sass/_media-tab.scss | Added imports with namespaced utility module access |
| app/assets/css/sass/_magnific.scss | Added variables import with wildcard namespace |
| app/assets/css/sass/_album.scss | Added variables import with wildcard namespace |
| app/assets/css/sass/_activity.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/admin.scss | Converted all @import statements to @use |
| app/assets/admin/css/sass/_variables.scss | Added sass:list module and namespaced list functions |
| app/assets/admin/css/sass/_tabs.scss | Added imports with layout namespace access |
| app/assets/admin/css/sass/_switch.scss | Added sass:color module and used color.adjust() instead of deprecated lighten()/darken() |
| app/assets/admin/css/sass/_sidebar.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/_rtmedia-pro.scss | Added sass:color module and used color.adjust() instead of deprecated functions |
| app/assets/admin/css/sass/_responsive.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/_layout.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/_components.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/_addons.scss | Added variables import with wildcard namespace |
| app/assets/admin/css/sass/widget.scss | Added variables import with wildcard namespace |
| app/assets/css/rtmedia.css | Updated generated CSS with properly formatted values |
| app/assets/admin/css/admin.css | Updated generated CSS with properly formatted values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NoumaanAhamed
requested review from
KMchaudhary,
Pradeep1308,
nayemDevs and
rtBot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart Sass 3.0.0 will introduce breaking changes by removing deprecated features. This PR removes the deprecated feature and ensures there are no warnings in the build step.
Addresses #2119