Skip to content

Conversation

@NoumaanAhamed
Copy link
Collaborator

  • ENHANCEMENT
    • Compatible with WordPress latest version 6.9
    • Compatible with PHP version 8.4
    • Updated magnific-popup library to latest version 1.2.0
    • Updated dependencies in node and composer packages to latest versions.
    • Made the overall code more robust and secure.

NoumaanAhamed and others added 30 commits December 5, 2025 12:30
fix(update) : PHP 8.4 Compatibility
…2242)

* chore(tests): update dependencies in wp-e2e-playwright package.json

* fix(workflow): update NODE_VERSION to 20 in Playwright CI configuration

* fix(workflow): revert NODE_VERSION to 17 in Playwright CI configuration
…or encoding (#2247)

* fix(importer): replace die() with exit() in BPMediaAlbumimporter

* Potential fix for code scanning alert no. 13: Incomplete string escaping or encoding
- Add permissions block to phpcs_on_pull_request.yml (contents: read, pull-requests: write)
- Add permissions block to create.yml (contents: read)
- Add permissions block to playwright.yml (contents: read)

This follows the principle of least privilege and resolves GitHub code scanning alerts #1, #2, and #39.

Fixes: rtCamp/support#245
fix: add explicit permissions to GitHub Actions workflows
* fix(importer): replace die() with exit() in BPMediaAlbumimporter

* fix: add explicit permissions to GitHub Actions workflows

- Add permissions block to phpcs_on_pull_request.yml (contents: read, pull-requests: write)
- Add permissions block to create.yml (contents: read)
- Add permissions block to playwright.yml (contents: read)

This follows the principle of least privilege and resolves GitHub code scanning alerts #1, #2, and #39.

Fixes: rtCamp/support#245

---------

Co-authored-by: rtBot <43742164+rtBot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* chore: update magnific popup to v1.2.0

* fix: improve close button markup handling and prependTo selector logic

* fix: resolve merge conflicts in close button markup and prependTo logic
Security-fix: remove unnecessary peer properties from dependencies
Security-fix: enhance security by safely parsing HTML
Update Docker image version in Playwright workflow
Copy link
Member

@mi5t4n mi5t4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtBot
Copy link
Contributor

rtBot commented Jan 6, 2026

Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:

  • app/assets/admin/js/settings.js
  • app/assets/js/rtMedia.backbone.js
  • app/assets/js/rtMedia.js
  • app/assets/js/vendors/magnific-popup.js
  • app/importers/BPMediaAlbumimporter.php
  • index.php

The error may be temporary. If the error persists, please contact a human (commit-ID: 183c160).

@Pradeep1308 Pradeep1308 merged commit beb8a54 into master Jan 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants