Add missing ostruct require until upstream fixes it#7561
Merged
deivid-rodriguez merged 1 commit intomasterfrom Apr 9, 2024
Merged
Add missing ostruct require until upstream fixes it#7561deivid-rodriguez merged 1 commit intomasterfrom
deivid-rodriguez merged 1 commit intomasterfrom
Conversation
deivid-rodriguez
force-pushed
the
deivid-rodriguez/missing-require
branch
from
b920afa to
89da6c1
Compare
ilyazub
reviewed
Apr 10, 2024
deivid-rodriguez
added a commit
that referenced
this pull request
Apr 11, 2024
Add missing ostruct require until upstream fixes it (cherry picked from commit b120ae6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
json dropped its dependency on ostruct in ruby-core. That surfaced that turbo_tests was using ostruct without requiring it first, since it was their json dependency actually doing that.
That broke our daily bundler specs.
What is your fix for the problem, implemented in this PR?
Add the missing require ourselves, for now.
Make sure the following tasks are checked