Fix compatibility with JRuby #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRuby's fiddle implementation has quite some shortcomings compared with the CRuby impl. Add JRuby tests in CI.
|
@larskanis Thank you for this patch! Perhaps we could get some of these things fixed in the ffi-fiddle as well? Both JRuby and TruffleRuby depend on that implementation, so it would be great if we can improve compatibility with the native version. Could you file an issue (or multiple) for the things that had to change here? |
Collaborator
Author
|
Main problem fixed here is the acceptance of integer where a pointer is expected in a function call. This will be solved by ruby/fiddle#162 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby's fiddle implementation has quite some shortcomings compared with the CRuby impl.
Add JRuby tests in CI.