Use environment variable to set CODEOWNERS write path #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleywillard
approved these changes
Jan 31, 2025
Contributor
ashleywillard
left a comment
ashleywillard
left a comment
There was a problem hiding this comment.
This seems like a good change. Another way to implement this would be to specify the codeowners path in the code_ownership.yml file.
Contributor
Author
|
@ashleywillard - I like that recommendation a little better. I'll see about doing that instead. |
Contributor
Author
|
@ashleywillard - How's this look now? |
ashleywillard
approved these changes
Jan 31, 2025
Contributor
ashleywillard
left a comment
ashleywillard
left a comment
There was a problem hiding this comment.
Looks good! cc @perryqh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the gem always defaults
CODEOWNERSto generate in.github/CODEOWNERS. This works well for projects that follow the same structure but doesn't work well for other structures (or other platforms). For example:CODEOWNERSin.github/,docs/or root.CODEOWNERSin.gitlab/,docs/or root.This change updates the path for the file location to pull from an environment variable (
CODEOWNERS_PATH) to use for the path. It will still default to the old behavior of using.github/to maintain backwards compatibility.