Refactor navbar class helpers #953
Merged
+87
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be clearer about what it returns.
because it returns a Regexp for matching path prefixes.
feels like it's nothing but this.
Currently, if no nav matches, both `@active_nav_key` and `@active_subnav_key` stay nil, and nil || nil is falsy, so we recalculate on every call.
to reduce methods and ivars
so the given request.path can dynamically match using current_event. This eliminates creation of Regexp objects, and reduces execution of url_for helpers.
since all path helpers are dynamically executed now, we can share this whole navigation map globally across all requests now.
so we can eliminate the Array case
where it used to be done twice. Also, we could finally eliminate a method that was defined for all controllers with too general name "match?".
with an assumption that subnav_item_class is always called AFTER nav_item_class was called at least once.
No need to define them in controllers, because we call them only from view files.
for intuitiveness.
because we don't use this anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the module that defines
nav_item_classandsubnav_item_classfrom a spaghetti jungle that pollutes all controllers with 13 methods to a super elegantly written fine tuned short piece of readable code that does not pollute anything at all.