Open
Conversation
ruediger
reviewed
Sep 19, 2019
| int size_r = width * height; | ||
| unsigned char* image_rev = new unsigned char[size_r]; | ||
| for (int i = 0; i < size_r; i++) | ||
| { |
Owner
There was a problem hiding this comment.
the bracket placement is inconsistent with the rest of the file
ruediger
reviewed
Sep 19, 2019
|
|
||
| if (inverting_images) { | ||
| int size_r = width * height; | ||
| unsigned char* image_rev = new unsigned char[size_r]; |
ruediger
reviewed
Sep 19, 2019
| bool inverting_images = true; | ||
|
|
||
| if (inverting_images) { | ||
| int size_r = width * height; |
Owner
There was a problem hiding this comment.
this should be size_t. Probably size_t const
| unsigned char* image_rev = new unsigned char[size_r]; | ||
| for (int i = 0; i < size_r; i++) | ||
| { | ||
| int val = static_cast<int>(image[i]); |
Author
|
I have zero experience with C. This seemed to have solved the problem I've had with tesseract 4. |
Geoffrey-A
added a commit
to Geoffrey-A/VobSub2SRT
that referenced
this pull request
Jun 21, 2020
This contains the following PRs: - ruediger#72 by bit: Fix compile with gcc7 and tesseract 4 - ruediger#75 by oltodosel: inverting images for tesseract 4
Geoffrey-A
added a commit
to Geoffrey-A/VobSub2SRT
that referenced
this pull request
Jun 21, 2020
Geoffrey-A
added a commit
to Geoffrey-A/VobSub2SRT
that referenced
this pull request
Jun 21, 2020
This contains the following PRs: - ruediger#72 by @bit: Fix compile with gcc7 and tesseract 4 - ruediger#75 by @oltodosel: inverting images for tesseract 4
Geoffrey-A
added a commit
to Geoffrey-A/VobSub2SRT
that referenced
this pull request
Jun 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tesseract-ocr/tesseract#2417
https://github.com/tesseract-ocr/tesseract/wiki/ImproveQuality#inverting-images