Skip to content

chore: add tests to test panic #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
coderbirju wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: add tests to test panic #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ func Exec(o *option.Option) {
ginkgo.AfterEach(func() {
command.RemoveAll(o)
})

ginkgo.It("should not panic when exec without arguments", func() {
// Test finch exec without arguments - should show help, not panic
session := command.New(o, "exec").WithoutCheckingExitCode().Run()
gomega.Expect(session.Out.Contents()).ShouldNot(gomega.BeEmpty()) // Should have output
})
// TODO: specifying -t flag will have error in test -> panic: provided file is not a console
ginkgo.When("then container is running", func() {
ginkgo.BeforeEach(func() {
Expand Down
6 changes: 6 additions & 0 deletions tests/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ func Run(o *RunOption) {
command.RemoveAll(o.BaseOpt)
})

ginkgo.It("should not panic when run without arguments", func() {
// Test finch run without arguments - should show help, not panic
session := command.New(o.BaseOpt, "run").WithoutCheckingExitCode().Run()
gomega.Expect(session.Out.Contents()).ShouldNot(gomega.BeEmpty()) // Should have output
})

ginkgo.When("running a container that echos dummy output", func() {
ginkgo.BeforeEach(func() {
dockerfile := fmt.Sprintf(`FROM %s
Expand Down