fix: finch run panic without arguments#1634
Merged
coderbirju merged 2 commits intorunfinch:mainfrom Dec 18, 2025
Merged
Conversation
pendo324
previously approved these changes
Dec 8, 2025
sondavidb
previously approved these changes
Dec 8, 2025
Member
|
Can we add a test, if its breaking that means we are missing a test for it somewhere. |
2312441 to
10a3458
Compare
sondavidb
reviewed
Dec 12, 2025
Shubhranshu153
previously approved these changes
Dec 13, 2025
03c0acf to
44be731
Compare
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
44be731 to
357c326
Compare
sondavidb
approved these changes
Dec 17, 2025
Swapnanil-Gupta
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes #1633
Description of changes:
Added a length check to prevent panic when run without arguments
Testing done:
Before
After
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.