Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,17 @@ $ ./local/check-dependencies.sh
```

Most dependencies are easily installed using a package manager, such as `brew`.
However, there are installation scripts for some dependencies, such as:
However, there are installation scripts for all dependencies, such as:

```
$ ./local/install-dependency-3proxy.sh
```

You can automatically install all missing dependencies by passing in the install flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --install too

```
$ ./local/check-dependencies.sh install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this --install to make it more clear that this is a toggle/flag.

```

## Running the Agent

To run the agent, you'll need your Reflect account API key,
Expand Down
14 changes: 13 additions & 1 deletion local/check-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ echo "Verifying agent dependencies"
echo "-----------------------------"

ExitCode=0
AutoInstall=$1

function pad() {
Result=" $1"
Expand All @@ -19,6 +20,10 @@ function failed() {
echo -e "\xE2\x9D\x8C failed"
}

function install() {
/bin/sh -c "./install-dependency-$1.sh"
}

function missingCommands() {
for command in "$@"; do
Exists=$(which $command)
Expand All @@ -34,9 +39,16 @@ function checkDependency() {
Missing=$(missingCommands $@)

echo -ne "${Name}: "
if [ $Missing ]; then failed ; else passed ; fi
if [ $Missing ] && [ $AutoInstall ] && [ $AutoInstall == "install" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the middle clause because all variables will be the empty string until defined. So, the second clause can be [ "$AutoInstall" == "--install" ]; then

then install $Name ;
elif [ $Missing ];
then failed ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our default syntax in other scripts is for the then to be on the preceding line after the semi-colon.

else
passed ;
fi
}

checkDependency "homebrew" "brew"
checkDependency "ifconfig" "ifconfig"
checkDependency "wireguard-tools" "wg" "wg-quick"
checkDependency "jq" "jq"
Expand Down
2 changes: 2 additions & 0 deletions local/install-dependency-homebrew.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
2 changes: 2 additions & 0 deletions local/install-dependency-jq.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
brew install jq
2 changes: 2 additions & 0 deletions local/install-dependency-websocat.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
brew install websocat
2 changes: 2 additions & 0 deletions local/install-dependency-wireguard-tools.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
brew install wireguard-tools