Added support for 128x128 size displays#31
Open
JFKingsley wants to merge 9 commits intorust-embedded-community:masterfrom
Open
Added support for 128x128 size displays#31JFKingsley wants to merge 9 commits intorust-embedded-community:masterfrom
JFKingsley wants to merge 9 commits intorust-embedded-community:masterfrom
Conversation
jamwaffles
requested changes
Feb 1, 2023
Collaborator
jamwaffles
left a comment
jamwaffles
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR! I left a few comments
| /// Get the panel column offset from DisplaySize | ||
| pub fn column_offset(self) -> u8 { | ||
| match self { | ||
| DisplaySize::Display128x128 => 2, |
Collaborator
There was a problem hiding this comment.
Just confirming this is the correct offset
Comment on lines
+52
to
+56
| Command::Contrast(0x80).send(&mut self.iface)?; | ||
| Command::SegmentRemap(false).send(&mut self.iface)?; | ||
| Command::Multiplex(128).send(&mut self.iface)?; | ||
| Command::DisplayOffset(0x60).send(&mut self.iface)?; | ||
| Command::DisplayClockDiv(0x8, 0x0).send(&mut self.iface)?; |
Collaborator
There was a problem hiding this comment.
I don't have hardware to test with on hand at the moment, but I'm concerned these changes will cause regressions for the currently supported display sizes. What are the minimum changes needed to support 128x128 displays?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Made some changes to support 128x128 displays and thought I'd merge it back upstream.
Not sure what your explicit PR requirements are, but let me know and I'll be happy to shuffle them in!