Merged
Conversation
lu-zero
approved these changes
Dec 31, 2024
dodomorandi
reviewed
Dec 31, 2024
Collaborator
Author
|
No, now I set self to None also when the socket reads an empty buffer
Il mar 31 dic 2024, 15:26 Edoardo Morandi ***@***.***> ha
scritto:
… ***@***.**** commented on this pull request.
------------------------------
In src/stream.rs
<#29 (comment)>:
> @@ -90,6 +91,16 @@ impl Stream for UEventsStream {
}
}
- Poll::Pending
+ if matches!(this, Self::None) {
+ Poll::Ready(None)
+ } else {
+ Poll::Pending
This should be unreachable, isn't it?
—
Reply to this email directly, view it on GitHub
<#29 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZXINO3FFS7KK5HSRJGQPD2IKSPRAVCNFSM6AAAAABUNKBF7CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRWGUYTANJQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Yes, but I mean, there is no way |
Collaborator
Author
|
Ah, yes, the else part... Yes, this should be unreachable, I would prefer a
panic over debugging a future that is never waken
Il mar 31 dic 2024, 15:30 Edoardo Morandi ***@***.***> ha
scritto:
… No, now I set self to None also when the socket reads an empty buffer
Yes, but I mean, there is no way this does *not* match None at that
point... or not?
—
Reply to this email directly, view it on GitHub
<#29 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZXINJWOJWE2IJN2II7QN32IKTBDAVCNFSM6AAAAABUNKBF7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGQ4TMNZTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
240d9e4 to
dc3ec78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.